Merge duplicate TM feature flags #7566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were 2 feature flags for ThreatMetrix behavior that conflicted: - `proofing_device_profiling_decisioning_enabled`: This determined whether or not a user saw the "sad face" screen - `lexisnexis_threatmetrix_required_to_verify`: This determined whether or not a user received an active profile after successful proofing There is no case where we want one and not the other or vice versa. Thus this commit merges them into a single `lexisnexis_threatmetrix_required_to_verify` config. [skip changelog]
mitchellhenke
approved these changes
Jan 3, 2023
mdiarra3
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 feature flags for ThreatMetrix behavior that conflicted:
proofing_device_profiling_decisioning_enabled: This determined whether or not a user saw the "sad face" screenlexisnexis_threatmetrix_required_to_verify: This determined whether or not a user received an active profile after successful proofingThere is no case where we want one and not the other or vice versa. Thus this commit merges them into a single
lexisnexis_threatmetrix_required_to_verifyconfig.[skip changelog]