Update GoodJob and re-remove concurrency controls #7491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellhenke
force-pushed
the
mitchellhenke/update-good-job-3
branch
from
6397497 to
3752b72
Compare
changelog: Internal, Background Jobs, Update GoodJob and remove concurrency controls
mitchellhenke
force-pushed
the
mitchellhenke/update-good-job-3
branch
from
ea99949 to
19fb61c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
We removed the concurrency controls in #7197 to improve throughput and reverted it in #7317 as the changes led to double-running cron jobs. GoodJob recently merged bensheldon/good_job#767, which should allow us to safely disable the concurrency controls and job record preservation (since cron jobs are always preserved now).
I've done some initial testing in my sandbox and not seen any double-run issues.