This repository has been archived by the owner on Dec 12, 2023. It is now read-only.
Control Implementation Summary (workbook) #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ohsh6o
reviewed
Jul 22, 2021
There was a problem hiding this comment.
I think for something like this we should sit together and do a code review. Can you, @danielnaab, and I arrange this tomorrow morning?
Perhaps before the ASAP P3 standup or the subsequent NIST OSCAL Model Review |
danielnaab
approved these changes
Jul 26, 2021
| implementation-status.</sch:diagnostic> | ||
| <sch:diagnostic doc:assertion="implemented-requirement-has-implementation-status-remarks" | ||
| doc:context="oscal:implemented-requirement" | ||
| id="implemented-requirement-has-implementation-status-remarks-diagnostic">Thgis incomplete control implementation lacks an |
There was a problem hiding this comment.
Suggested change
| id="implemented-requirement-has-implementation-status-remarks-diagnostic">Thgis incomplete control implementation lacks an | |
| id="implemented-requirement-has-implementation-status-remarks-diagnostic">This incomplete control implementation lacks an |
danielnaab
pushed a commit
that referenced
this pull request
Jul 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation rules not previously present, specifically those in §5.3 and §5.3.1.1.
Closes #48.
Closes #101.
The actual "CIS Workbook" will be a separate PR.