This repository has been archived by the owner on Dec 3, 2017. It is now read-only.
Contact form styles #627
Merged
Contact form styles #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report@@ Coverage Diff @@
## master #627 +/- ##
=======================================
Coverage 79.52% 79.52%
=======================================
Files 29 29
Lines 1470 1470
Branches 216 216
=======================================
Hits 1169 1169
Misses 301 301Continue to review full report at Codecov.
|
xtine
approved these changes
Feb 8, 2017
scss/components/_contact-form.scss
Outdated
| background-position: right 10px top 50%; | ||
| } | ||
|
|
||
| .hr--soft { |
There was a problem hiding this comment.
Just kind of a minor nitpick, but I think the hr naming convention might make more sense to follow the color variables, so like .hr and .hr--dark (and .hr--light if using $gray-light). What do you think?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some styles for the contact form in https://github.com/18F/fec-cms/pull/755#issuecomment-278198318