This repository has been archived by the owner on Dec 17, 2021. It is now read-only.
Remove now-broken hack and replace with proper solution #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally [a hack was put in place to disable automatic Lambda retries](boto/boto3#1104) because boto3 lacked support for this. Unfortunately this hack no longer works with the latest boto3 code because it touches internal variables that apparently have been removed or renamed. Fortunately, though, [support for disabling automatic retries has been added](boto/botocore#1260).
jsf9k
changed the title
|
This is a pretty big deal, since |
IanLee1521
approved these changes
Sep 15, 2018
There was a problem hiding this comment.
Looks great!
For those later looking for the reference, see: boto/boto3#1104 (comment)
|
See also: boto/botocore#1260 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally a hack was put in place to disable automatic Lambda retries because
boto3lacked support for this. Unfortunately this hack no longer works with the latestboto3code because it touches internal variables that apparently have been removed or renamed. Fortunately, though, support for disabling automatic retries has been added.