This repository has been archived by the owner on Sep 19, 2021. It is now read-only.
don't jump to top when navigating within a page #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue with page scrolling up when navigating within a page.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #502.
The problem
When navigation between sections using keyboard input, focus would stay on the sidebar unless forced elsewhere. (remix-run/react-router#5210)
The solution for https://github.com/ryanhofdotgov/e-QIP-prototype-truetandem/issues/1358 was to to move focus to the main content area whenever the
Sectioncomponent was "updated". Unfortunately, this was too aggressive, and would also be triggered when navigating within the page.The solution
Only move focus when the browser URL path changes, and do so using a more reliable means of referencing the element.