This repository has been archived by the owner on Sep 12, 2019. It is now read-only.
Add new section to About page https://github.com/18F/eregs-platform/issues/57 #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2016
cmc333333
reviewed
Sep 20, 2016
| margin-left: -32px; | ||
| color: green; | ||
| border: 10px solid red; | ||
| } |
There was a problem hiding this comment.
Should this rule be removed? The class name includes an x at the beginning.
There was a problem hiding this comment.
Yup, removed.
cmc333333
reviewed
Sep 20, 2016
| xcolor: #071635; | ||
| color: #d14124; | ||
| font-size: 18px; | ||
| } |
There was a problem hiding this comment.
This is a bit gnarly; what about using this instead?
<span class="cf-icon cf-icon-delete-round">There was a problem hiding this comment.
So much cleaner, thanks!
cmc333333
reviewed
Sep 20, 2016
| <li>The <strong>date picker</strong> allows users to find what revision was effective on a specific date.</li> | ||
| <li><strong>Federal Register notice(s)</strong> associated with a revision are presented and organized by publication date. These links will | ||
| take you to the notice on the Office of the Federal Register’s website.</li> | ||
| <li><strong>Compare</strong> any two revisions of the regulation, word for word, by selecting a date in the menu and clicking “Show Differences”.</li> |
cmc333333
approved these changes
Sep 21, 2016
| } | ||
|
|
||
| .icon-red { | ||
| color: #d14124; |
There was a problem hiding this comment.
It's a shame we're using a hard-coded color in -site here, but thanks for highlighting that. Created eregs/regulations-site#463
cmc333333
reviewed
Sep 21, 2016
| color: #d14124; | ||
| } | ||
|
|
||
| img.about-stopcompare-img { |
There was a problem hiding this comment.
NBD, but per https://pages.18f.gov/frontend/#css-specificity, this shouldn't include the img
There was a problem hiding this comment.
Good point; addressed here #445
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use “Stop Comparing” /
Now that we have a section /
Clarifying it.