Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating new admin accounts fails in Firefox #271

Closed
GUI opened this issue Aug 26, 2015 · 2 comments
Closed

Creating new admin accounts fails in Firefox #271

GUI opened this issue Aug 26, 2015 · 2 comments

Comments

@GUI
Copy link
Member

GUI commented Aug 26, 2015

  • In the admin, go to the Users > Admin Accounts and click the "Add New Admin" button.
  • Fill out a username and select a group for the admin to belong to.
  • Click Save.

In Chrome and Safari this appears to work as intended. However, in Firefox the save will fail with a validation error claiming that you haven't checked anything for groups:

Groups: must belong to at least one group or be a superuser

It does look like these form submissions from Firefox are somehow getting submitted with an empty group_ids array despite the checkboxes being checked.

This has been seen under Firefox 40.0 (Linux) and Firefox 38.2 (Mac).

When we figure out what's going on, we should ensure this isn't also an issue in Internet Explorer, and also verify that this isn't more widespread to to some of our other admin forms that use checkboxes.

@GUI
Copy link
Member Author

GUI commented Aug 26, 2015

Fixed by NREL/api-umbrella-web@015bb01

We actually had test coverage that would have caught this issue, but since our test suite only executes in webkit, we missed this firefox issue. I opened a separate issue for us to get our integration test suite running in other real browsers, like Firefox: #272

@GUI GUI closed this as completed Aug 26, 2015
@GUI
Copy link
Member Author

GUI commented Aug 26, 2015

Oh, and I also did some additional testing in IE11, and things appear to be working fine there. I'm also pretty sure this bug was isolated to just the checkboxes in a couple lists of checkbox in the admins form and admin groups form. Other checkboxes don't look like they were affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant