Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Object|null and ?Object final class as property type #64

Conversation

frankdekker
Copy link
Member

The custom value provider only supports private FinalClass $object and not private ?FinalClass $object. This PR adds support for the latter.

@frankdekker frankdekker requested a review from a team as a code owner November 27, 2024 21:04
@frankdekker frankdekker requested review from bram123 and removed request for bram123 November 27, 2024 21:04
@frankdekker frankdekker changed the title Allow for Object|null and ?Object final class type Allow for Object|null and ?Object final class as property type Nov 27, 2024
@bram123 bram123 merged commit 0729fef into 123inkt:master Nov 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants