chore: Use node: protocol in imports
#168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The official docs have used the prefix in examples for years. According to the NodeJS docs for [Modules (§Core Modules)](https://nodejs.org/dist/latest-v18.x/docs/api/modules.html#core-modules), the `node:` “protocol” was added in NodeJS v16.0.0 (initial release 2021-04-20; [source](https://nodejs.dev/en/about/releases/)) and (probably experimentally…?) v14.18.0 (released 2021-09-08; [source](https://nodejs.org/en/blog/release/v14.18.0)). Personally, I like how it makes it easy to distinguish 3rd party modules (no prefix) from core modules (`node:` prefix) and local modules (`./` or `../` prefix).
|
I haven’t found this to work in Node 14, which is our current Node minimum for a bit longer! |
|
Okay, thanks! 🙏🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official docs have used the prefix in examples for years.
According to the NodeJS docs for Modules (§Core Modules), the
node:“protocol” was added in:probablypossibly experimentally…?) v14.18.0 (released 2021-09-08; source)Personally, I like how it makes it easy to distinguish:
node:prefix) and./or../prefix).