Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #967, I tried to refactor the
getTemplateData
function inEleventyFiles.js
by replacing theif
andreturn
by a ternary operator.My refactor broke the caching but all the tests passed nonetheless.
On closing the PR, @zachleat said:
So here is the PR that adds a test around this.
What it does is simply call the
getTemplateData
function twice in a row and compares the return values.Since the
getTemplateData
function returns an object, we can compare the object reference by using theis
test.I've been successfully able to break my test by removing the caching mechanism. In that case, the test result says:
Which is what we would expect without caching.