Support for cjs extension in global and local data files #848
Conversation
and fixes a lot of checks of data files listings in old tests
|
Now that #821 is merged do we need to make additional changes here? |
|
I need to add some changes to this PR based on #821 approval and resolve conflicts. I probably will commit a new version on weekend |
|
There is a bug in a new version of the ava test runner. It injects some custom stuff into require.extensions and breaks |
|
Oh well that’s terrible @gloryofrobots! Some discussion about this here avajs/ava#2293 |
|
I made a PR for ava (or to be precise for a small project in the ava domain) which is hopefully will fix the problem. But I do not know when it will be merged. The good news is that because it is not a fix for Ava itself but for Ava dependency the adoption may be faster. |
|
Ava team merged my fix! I will update this branch soon |
# Conflicts: # package.json # src/TemplateData.js # test/UserDataExtensionsTest.js # test/stubs-630/_data/mergingGlobalData.js # test/stubs-630/_data/mergingGlobalData.json # test/stubs-630/_data/mergingGlobalData.nosj # test/stubs-630/_data/mergingGlobalData.yaml
|
Ok, work is done. I bumped ava/babel version in package.json to 1.0.1 to include fix for the bug mentioned above. |
|
Fixed new conflicts |
zachleat
added
enhancement
and removed
bug: dependency
|
YESSSSS Thank you for your awesome work here, including going above and beyond and fixing a dependency too! Wow! |
Implements support of
.cjs(common js) extension in global and local data files as requested in #837 Places.cjsbefore.jsin priority ordering for local files. For global data order, I need to wait while #821 gets merged.Changes are very trivial in both the TemplateData.js and tests but a lot of tests were changed due to local data file lists checks.