Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3425 import of Liquid.js #3426

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix #3425 import of Liquid.js #3426

merged 1 commit into from
Aug 30, 2024

Conversation

lexoyo
Copy link
Contributor

@lexoyo lexoyo commented Aug 27, 2024

Fix #3425

This changes the import of liquidjs to proper import (same as in liquidjs's docs i mean)

It works with the latest version of liquidjs (10.16.5)

@lexoyo lexoyo requested a review from zachleat as a code owner August 27, 2024 19:34
@lexoyo lexoyo changed the title fix import of Liquid.js fix #3425 import of Liquid.js Aug 27, 2024
Copy link
Member

@zachleat zachleat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zachleat zachleat added this to the Eleventy 3.0.0 milestone Aug 30, 2024
@zachleat
Copy link
Member

Shipping with 3.0.0-beta.2 and 3.0.0-alpha.19

@zachleat zachleat merged commit c4a8db2 into 11ty:main Aug 30, 2024
9 checks passed
@zachleat
Copy link
Member

Merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LiquidJS import broken as of latest version, 10.16.5
2 participants