Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line numbers #24

Closed
wants to merge 2 commits into from
Closed

Add line numbers #24

wants to merge 2 commits into from

Conversation

pborenstein
Copy link
Contributor

Building on the work of @andeersg in #14.

Requires #23

left as an exercise for the reader:

  • 1-based numbering
  • per-block line numbering
  • implement for njk and liquid

@danilopolani
Copy link

Is there any chance we see this merged? Of course after solving the conflicts 😄 @zachleat

@JDubbTX
Copy link

JDubbTX commented Nov 20, 2023

I'm looking at using 11ty for my blog which is in infancy. I need a good blog starter - found several 11ty blog starters and zeroed in on one that I liked - but line numbers for examples in my blog is an absolute must. Can we please get this done?

-edit- for now I'll follow instructions in the link above for How to show line numbers and see if I can get that to work.

@pborenstein
Copy link
Contributor Author

@JDubbTX I don't think this will ever get merged. I made an alternate version: https://www.npmjs.com/package/@pborenstein/eleventy-md-syntax-highlight

@JDubbTX
Copy link

JDubbTX commented Nov 29, 2023

@JDubbTX I don't think this will ever get merged. I made an alternate version: https://www.npmjs.com/package/@pborenstein/eleventy-md-syntax-highlight

@pborenstein Unfortunately, the alternate version doesn't allow a custom language. I'm writing a blog about rpgle language, which isn't one of the prism.js languages. The original plugin has an init callback I was using to define the custom language for rpgle. I would like to 1) define a custom language and 2) use line numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants