Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Block Registration to Happen Automatically for any blocks containing a block.json file #78

Merged
merged 8 commits into from
Feb 25, 2022
Merged

Update Block Registration to Happen Automatically for any blocks containing a block.json file #78

merged 8 commits into from
Feb 25, 2022

Conversation

fabiankaegy
Copy link
Member

Description of the Change

This changes the block registration flow so that all blocks located within the directory that have a block.json file get automatically registered.

They also automatically get their added if the directory where the file is located also contains a file

Closes #62

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @

@fabiankaegy
update block registration to happen automatically
4770315 
This changes the block registration flow so that all blocks located within the  directioy that have a block.json file get automatically registered.

They also automatically get their  added if the directory where the  file is located also contains a  file
@fabiankaegy fabiankaegy added the enhancement New feature or request label Jan 24, 2022
@fabiankaegy fabiankaegy self-assigned this Jan 24, 2022
@fabiankaegy fabiankaegy mentioned this pull request Jan 24, 2022
Closed
joesnellpdx
joesnellpdx reviewed Feb 1, 2022
View reviewed changes
Copy link
Contributor

@joesnellpdx joesnellpdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the open comment left for @tlovett1 , this is approved by me.

@gthayer gthayer self-requested a review February 2, 2022 15:47
@gthayer gthayer self-assigned this Feb 2, 2022
@fabiankaegy
Copy link
Member Author

@gthayer I have updated this PR based on how #85 includes all the files. In my testing, this still works and feels much lass hacky. Let me know what you think.

@fabiankaegy fabiankaegy requested a review from gthayer February 25, 2022 16:09
@gthayer
Copy link

gthayer commented Feb 25, 2022

LGTM!

@fabiankaegy fabiankaegy merged commit 1dddfef into trunk Feb 25, 2022
@fabiankaegy fabiankaegy deleted the feature/enhance-block-registration branch February 25, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gthayer gthayer gthayer left review comments

@joesnellpdx joesnellpdx joesnellpdx left review comments

@tlovett1 tlovett1 Awaiting requested review from tlovett1

Assignees

@gthayer gthayer

@fabiankaegy fabiankaegy

Labels
enhancement New feature or request Internal Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify & standardize how to add custom blocks to the theme scaffold
3 participants
@fabiankaegy @gthayer @joesnellpdx