Removing the $n function #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function makes it difficult for IDEs to work correctly as they’re dynamically defined. It also doesn’t play nice with static analysis systems. Fixes #246
fabiankaegy
reviewed
Nov 25, 2024
Co-authored-by: Fabian Kägy <[email protected]>
darylldoyle
force-pushed
the
feature/remove-n-function
branch
from
72871ef to
73333e7
Compare
|
This makes me so happy ❤️ IDE integration and dead code detection ftw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This function makes it difficult for IDEs to work correctly as they’re dynamically defined. It also doesn’t play nice with static analysis systems.
Closes #246
How to test the Change
Tested Locally
Changelog Entry
$nfunction, in preference of passing the namespace manuallyChecklist:
I have updated the documentation accordingly.I have added Critical Flows, Test Cases, and/or End-to-End Tests to cover my change.