Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 10up-toolkit to version 4.3 and update blocks to use useBlockAssets feature #154

Merged
merged 5 commits into from
Nov 2, 2022

Conversation

fabiankaegy
Copy link
Member

in version 4.2 of toolkit the way block assets get handled got updated to use asset keys from the individual block.json file for entrypoint management

See: 10up/10up-toolkit#195

in version 4.2 of toolkit the way block assets get handled got updated to use asset keys from the individual block.json file for entrypoint management
@fabiankaegy fabiankaegy self-assigned this Aug 1, 2022
@fabiankaegy
Copy link
Member Author

I'm leaving this as a Draft PR till the final version of 4.2 gets released.

CC: @nicholasio @Antonio-Laguna

@joesnellpdx
Copy link
Contributor

@fabiankaegy can we add this PR to the 4.2 update? #164
The regex works as expected. Thanks !

@fabiankaegy fabiankaegy marked this pull request as ready for review October 31, 2022 11:24
@fabiankaegy fabiankaegy changed the title update 10up-toolkit to version 4.2 Update 10up-toolkit to version 4.3 and update blocks to use useBlockAssets feature Oct 31, 2022
@fabiankaegy fabiankaegy added the enhancement New feature or request label Oct 31, 2022
@fabiankaegy
Copy link
Member Author

Thanks for the 👍

My plan currently is to add something to the toolkit docs about this, update the Gutenberg training with this new approach, and include this in a blog post.

@fabiankaegy
Copy link
Member Author

This is the PR to update the docs of toolkit: 10up/10up-toolkit#247

@fabiankaegy fabiankaegy merged commit 077fe06 into trunk Nov 2, 2022
@fabiankaegy fabiankaegy deleted the feature/update-toolkit-version branch November 2, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants