Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cypress Utils and related packages. #160

Merged
merged 6 commits into from
Sep 14, 2023

Conversation

peterwilsoncc
Copy link
Contributor

@peterwilsoncc peterwilsoncc commented Sep 11, 2023

Description of the Change

This upgrades Cypress and the 10up Cypress Utilities and refactors the E2E tests to account for compatibility changes.

This also resolves the issues in dependabot's PR #157

Closes #155

How to test the Change

  1. Check E2E tests are passing on this PR's checks tab.
  2. Run the E2E tests locally:
    1. Ensure you are running the node versions specified in the nvmrc file (16)
    2. npm i; composer i; npm run build;
    3. npm run env destroy
    4. npm run env:start
    5. npm run cypress:run

Changelog Entry

Changed - Updated 10up Cypress Utilities to 0.2.0
Security - Update @cypress/request to 3.0.0 to resolve SSRF issue

Credits

Props @peterwilsoncc, @iamdharmesh, @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul modified the milestones: Future Release, 2.6.0 Sep 13, 2023
@peterwilsoncc peterwilsoncc marked this pull request as ready for review September 14, 2023 02:25
@peterwilsoncc peterwilsoncc requested a review from a team as a code owner September 14, 2023 02:25
@peterwilsoncc peterwilsoncc requested review from dkotter and removed request for a team September 14, 2023 02:25
@github-actions github-actions bot added the needs:code-review This requires code review. label Sep 14, 2023
@dkotter
Copy link
Collaborator

dkotter commented Sep 14, 2023

Looks good! The last merge (seems it was an automated refresh) doesn't show all the tests but looking at the last real merge, all tests are passing: https://github.com/10up/simple-page-ordering/actions/runs/6154899578

@peterwilsoncc peterwilsoncc merged commit ed8e540 into develop Sep 14, 2023
@peterwilsoncc peterwilsoncc deleted the do/155-upgrade-cypress-utils branch September 14, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Cypress to version 13
3 participants