Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress integration migrated to 11+ #120

Merged
merged 6 commits into from
Jan 23, 2023
Merged

Cypress integration migrated to 11+ #120

merged 6 commits into from
Jan 23, 2023

Conversation

jayedul
Copy link
Contributor

@jayedul jayedul commented Dec 6, 2022

Description of the Change

Cypress integration migrated to 11+

Closes #116

How to test the Change

  • Install NPM dependencies
  • Run npm run cypress:run to test without GUI
  • Run npm run cypress:open to test with GUI
  • Check if tests pass successfully

Changelog Entry

Changed - Cypress integration migrated to 11+

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jayedul jayedul requested a review from dkotter December 6, 2022 12:44
@jayedul jayedul self-assigned this Dec 6, 2022
@jeffpaul jeffpaul added this to the 2.5.0 milestone Dec 22, 2022
@jeffpaul
Copy link
Member

@jayedul are there any additional work needed here or can this PR come out of draft for review?

@jayedul
Copy link
Contributor Author

jayedul commented Jan 11, 2023

@jeffpaul
This pull request is ready. However the Github action is failing due to WP ENV setup issue. I just checked it happens in all other opened PR also.

As it looks like, WP minimum version attempts to run on updated PHP environment. That's why we see the error PHP Fatal error: Uncaught Error: Call to undefined function get_magic_quotes_gpc() in /var/www/html/wp-includes/load.php:651

@jayedul jayedul marked this pull request as ready for review January 11, 2023 09:56
@jayedul jayedul requested a review from a team as a code owner January 11, 2023 09:56
Sidsector9
Sidsector9 requested changes Jan 18, 2023
View reviewed changes
package.json Show resolved Hide resolved
tests/cypress/config.config.js
@@ -0,0 +1,18 @@
const { defineConfig } = require('cypress')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this to config.js

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can. Then it should be changed in package.json file too. That's all, I believe. I didn't change as it was automatically migrated from config.json by cypress.

@Sidsector9
Copy link
Member

@jayedul I have synced the latest develop with this branch, all expect trunk is passing. Can you please check?

@Sidsector9 Sidsector9 removed the request for review from dkotter January 18, 2023 04:39
@jayedul
Copy link
Contributor Author

jayedul commented Jan 20, 2023

@Sidsector9
Now all the tests pass successfully.

@Sidsector9 Sidsector9 self-requested a review January 23, 2023 06:34
Sidsector9
Sidsector9 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for working on this @jayedul
LGTM 👍

@Sidsector9 Sidsector9 merged commit 683f312 into develop Jan 23, 2023
@Sidsector9 Sidsector9 deleted the fix/116 branch January 23, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sidsector9 Sidsector9 Sidsector9 approved these changes

Assignees

@jayedul jayedul

Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

Migrate to Cypress 11
3 participants
@jayedul @jeffpaul @Sidsector9