Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for the front end #219

Merged
merged 13 commits into from
Oct 13, 2023
Merged

Conversation

Firestorm980
Copy link
Contributor

@Firestorm980 Firestorm980 commented Jun 29, 2023

Description of the Change

PR adds E2E tests for checking the front end of avatars

Closes #188

How to test the Change

  1. Check out the branch
  2. Run npm install and npm run build
  3. Start the WP environment with npm run env:start
  4. Run the tests with npm run cypress:run
  5. Verify all tests pass

Changelog Entry

Added - E2E test for checking the front end of avatars

Credits

Props @Firestorm980

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 2.7.6 milestone Jul 3, 2023
@jeffpaul jeffpaul requested review from a team and iamdharmesh and removed request for faisal-alvi and a team July 10, 2023 21:04
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Firestorm980 and apologies for the delayed PR review.

I can see E2E test actions are failing. could you please help to check on it?

Thanks

@jeffpaul
Copy link
Member

@iamdharmesh if you're able to help get that test fixed up (or a functional fix in the code if the test is failing for a good reason), then that would best help move this along... thanks!

@faisal-alvi faisal-alvi modified the milestones: 2.7.6, 2.7.7 Oct 11, 2023
@github-actions github-actions bot added the needs:feedback This requires feedback to determine next steps. label Oct 13, 2023
@github-actions
Copy link
Contributor

@Firestorm980 thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

@github-actions github-actions bot added needs:code-review This requires code review. and removed needs:feedback This requires feedback to determine next steps. labels Oct 13, 2023
@iamdharmesh iamdharmesh merged commit 86ae951 into develop Oct 13, 2023
11 checks passed
@iamdharmesh iamdharmesh deleted the feature/188-add-cypress-test-for-fe branch October 13, 2023 13:08
@jeffpaul jeffpaul modified the milestones: 2.7.7, 2.7.6 Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Cypress test to insure Avatars loaded at FE without errors
4 participants