Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep/325: Add blueprint.json #330

Merged
merged 6 commits into from
Sep 25, 2024
Merged

upkeep/325: Add blueprint.json #330

merged 6 commits into from
Sep 25, 2024

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Sep 6, 2024

Description of the Change

Closes #325

Adds blueprint.json file.

Changelog Entry

Developer - Support for the WordPress.org plugin preview

Credits

Props @jeffpaul @Sidsector9

Checklist:

@Sidsector9 Sidsector9 requested a review from jeffpaul as a code owner September 6, 2024 12:07
@github-actions github-actions bot added this to the 7.6.0 milestone Sep 6, 2024
@github-actions github-actions bot added the needs:feedback This requires feedback to determine next steps. label Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

@Sidsector9 thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

@jeffpaul
Copy link
Member

jeffpaul commented Sep 6, 2024

@Sidsector9 mind sharing a URL that uses this file via the branch to test in WP Playground to validate its working as expected?

Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sidsector9 this still needs the repo badge as noted in the task list in #325, see https://github.com/10up/maps-block-apple/blob/develop/README.md for an example

"landingPage": "/wp-admin/options-reading.php",
"preferredVersions": {
"php": "7.4",
"wp": "6.4"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking we should set this to latest so we're not having to constantly bump this version

@Sidsector9 Sidsector9 requested a review from dkotter September 25, 2024 18:48
Copy link
Collaborator

@dkotter dkotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkotter dkotter merged commit 00e5fde into develop Sep 25, 2024
10 of 14 checks passed
@dkotter dkotter deleted the upkeep/325 branch September 25, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:feedback This requires feedback to determine next steps.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add WordPress Playground integration
3 participants