Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Cypress to version 13 #276

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Upgrade Cypress to version 13 #276

merged 4 commits into from
Oct 17, 2023

Conversation

iamdharmesh
Copy link
Member

Description of the Change

This PR upgrades the Cypress, Cypress utils lib, and @wordpress/env. Updates needed files as part of the upgrade.

  • Bump Cypress version from 10.3.0 to 13.2.0
  • Bump @10up/cypress-wp-utils version to 0.2.0
  • Bump @wordpress/env version from 5.4.0 to 8.7.0

Closes #272

How to test the Change

Make sure PR PASS E2E tests check OR verify E2E tests locally.

Changelog Entry

Changed - Bump Cypress version from 10.3.0 to 13.2.0
Changed - Bump @10up/cypress-wp-utils version to 0.2.0
Changed - Bump @wordpress/env version from 5.4.0 to 8.7.0

Credits

Props @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions github-actions bot added this to the Future Release milestone Sep 14, 2023
@github-actions github-actions bot added the needs:code-review This requires code review. label Sep 14, 2023
@jeffpaul jeffpaul modified the milestones: Future Release, 7.4.1 Sep 14, 2023
@iamdharmesh iamdharmesh marked this pull request as draft September 14, 2023 15:21
@github-actions github-actions bot removed the needs:code-review This requires code review. label Sep 14, 2023
@github-actions github-actions bot removed the request for review from Sidsector9 September 14, 2023 15:21
@iamdharmesh iamdharmesh mentioned this pull request Sep 15, 2023
Closed
@jeffpaul
Copy link
Member

@iamdharmesh is this still a work-in-progress or can this move out of draft and for review/merge?

@iamdharmesh
Copy link
Member Author

@jeffpaul This is blocked by #278. The plugin is not getting built due to the composer package installation error, it will be fixed with #278

@Sidsector9 Sidsector9 marked this pull request as ready for review October 17, 2023 05:22
@github-actions github-actions bot added the needs:code-review This requires code review. label Oct 17, 2023
Sidsector9
Sidsector9 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @iamdharmesh
Changes look good, approving 👍

@Sidsector9 Sidsector9 merged commit d195e08 into develop Oct 17, 2023
13 checks passed
@Sidsector9 Sidsector9 deleted the tests/272 branch October 17, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sidsector9 Sidsector9 Sidsector9 approved these changes

Assignees

@iamdharmesh iamdharmesh

Labels
needs:code-review This requires code review.
Projects
None yet
Milestone
7.4.1
Development

Successfully merging this pull request may close these issues.

Upgrade Cypress to version 13
3 participants
@iamdharmesh @jeffpaul @Sidsector9