Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.2.4 #140

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Release/1.2.4 #140

merged 3 commits into from
Feb 29, 2024

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Feb 28, 2024

Description of the Change

Version bump and prep for the 1.2.4 release

Closes #139

How to test the Change

Verify all file changes look accurate

Changelog Entry

n/a

Credits

Props @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter added this to the 1.2.4 milestone Feb 28, 2024
@dkotter dkotter self-assigned this Feb 28, 2024
@dkotter dkotter requested a review from jeffpaul as a code owner February 28, 2024 17:14
@@ -33,6 +33,7 @@
"grunt-phpunit": "^0.3.6",
"grunt-wp-readme-to-markdown": "^2.0.1",
"load-grunt-tasks": "^5.1.0",
"mochawesome-json-to-md": "^0.7.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this was added on purposed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the newest version of this dependency causes our E2E tests to show as failed because the summary can't be updated correctly. See https://github.com/10up/eight-day-week/actions/runs/8084407853/job/22089631355. We've been downgrading this to the prior version across our repos, though would be great to figure out if there's a better work around that allows us to run the newest version

Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for handling the release!

@dkotter dkotter merged commit e7eeea2 into develop Feb 29, 2024
8 of 9 checks passed
@dkotter dkotter deleted the release/1.2.4 branch February 29, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release version 1.2.4
2 participants