Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix php warning and update tested wp version #136

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

dhanendran
Copy link
Member

Description of the Change

Fixed the PHP warning reported in #135 and updated tested WP version to 6.4.

Closes #135

How to test the Change

Changelog Entry

Fixed - Undefined array key PHP warning

Credits

Props @dhanendran

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dhanendran dhanendran requested a review from a team as a code owner November 24, 2023 10:59
@dhanendran dhanendran requested review from peterwilsoncc and removed request for a team November 24, 2023 10:59
@jeffpaul jeffpaul added this to the 1.3.0 milestone Nov 28, 2023
@jeffpaul
Copy link
Member

jeffpaul commented Jan 2, 2024

@peterwilsoncc bumping back onto your radar for code review

Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I was unable to reproduce the issue reported during comptability testing (it was possibly fixed in WP during the beta/RC phase) but the change make sense as a defensive coding measure.

@peterwilsoncc peterwilsoncc merged commit b82f92b into develop Jan 8, 2024
3 of 7 checks passed
@peterwilsoncc peterwilsoncc deleted the fix/135 branch January 8, 2024 00:43
@dkotter dkotter modified the milestones: 1.3.0, 1.2.4 Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The plugin hasn't been tested with the latest version of WordPress
4 participants