Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to conform to WP coding standards #118

Closed
1 task done
bmarshall511 opened this issue Jun 13, 2023 · 5 comments · Fixed by #120
Closed
1 task done

Update code to conform to WP coding standards #118

bmarshall511 opened this issue Jun 13, 2023 · 5 comments · Fixed by #120
Assignees
Labels
type:enhancement New feature or request.
Milestone

Comments

@bmarshall511
Copy link
Contributor

bmarshall511 commented Jun 13, 2023

Is your enhancement related to a problem? Please describe.

Creating this to better track the progress of updating the code to better comply with WP coding standards, see #117 (comment)

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@bmarshall511 bmarshall511 added the type:enhancement New feature or request. label Jun 13, 2023
@bmarshall511 bmarshall511 self-assigned this Jun 13, 2023
@bmarshall511
Copy link
Contributor Author

👋 @jeffpaul @peterwilsoncc, I've tackled most of the coding standards issues 🛠️, but there are still a few left concerning hook names using slashes vs. underscores. I'm a bit hesitant to make these updates, as others might be utilizing those hooks in their implementations and I don't want to accidentally break anything 😅. Additionally, there's quite a bit to address regarding processing form data without nonce verification. It seems like that will require more extensive work than just updating a few lines, so it might be better to handle it through a separate issue. Let me know what you all think. 💭

@jeffpaul
Copy link
Member

@bmarshall511 splitting out the different concerns into separate PRs should help ensure the "easy" ones get out quickly while any deeper conversations only hold up the more "complex" updates

@bmarshall511
Copy link
Contributor Author

Sounds good @jeffpaul! I went ahead and submitted a PR for the first round of the easy ones 👆 Once reviewed & merged, do you wanna keep this open to track the harder ones or open a new issue?

@jeffpaul
Copy link
Member

@bmarshall511 fine to keep this one open or open a subsequent one with specifics on the more complex updates, dealers choice.

@jeffpaul jeffpaul added this to the 1.3.0 milestone Jun 27, 2023
@jeffpaul jeffpaul moved this from Incoming to In Review in Open Source Practice Jun 27, 2023
@bmarshall511
Copy link
Contributor Author

@jeffpaul Sounds good, I'll just leave this open & updated the desc. Running the linter should provide enough specifics of what's remaining.

@github-project-automation github-project-automation bot moved this from In Review to Merged in Open Source Practice Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants