-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code to conform to WP coding standards #118
Comments
👋 @jeffpaul @peterwilsoncc, I've tackled most of the coding standards issues 🛠️, but there are still a few left concerning hook names using slashes vs. underscores. I'm a bit hesitant to make these updates, as others might be utilizing those hooks in their implementations and I don't want to accidentally break anything 😅. Additionally, there's quite a bit to address regarding processing form data without nonce verification. It seems like that will require more extensive work than just updating a few lines, so it might be better to handle it through a separate issue. Let me know what you all think. 💭 |
@bmarshall511 splitting out the different concerns into separate PRs should help ensure the "easy" ones get out quickly while any deeper conversations only hold up the more "complex" updates |
Sounds good @jeffpaul! I went ahead and submitted a PR for the first round of the easy ones 👆 Once reviewed & merged, do you wanna keep this open to track the harder ones or open a new issue? |
@bmarshall511 fine to keep this one open or open a subsequent one with specifics on the more complex updates, dealers choice. |
@jeffpaul Sounds good, I'll just leave this open & updated the desc. Running the linter should provide enough specifics of what's remaining. |
Is your enhancement related to a problem? Please describe.
Creating this to better track the progress of updating the code to better comply with WP coding standards, see #117 (comment)
Designs
No response
Describe alternatives you've considered
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: