-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate WPAcceptance tests to Cypress #941
Conversation
@@ -49,9 +49,6 @@ jobs: | |||
npx wp-env run cli "wp core version" | |||
npx wp-env run cli "php --version" | |||
|
|||
- name: Convert to multisite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See tests/bin/initialize.sh
…o tests/migrate-wpacc-cypress
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on this @cadic! LGTM 👍
@Sidsector9 this is an unfinished work, still needs some tests to be migrated |
@peterwilsoncc FYI on this in-progress work here that we'll want to ensure gets wrapped before v2 is released so we can ensure these run & validate the refactoring work you're leading |
I'll resolve the merge conflicts on this and merge the progress if everything is working as expected. |
# Conflicts: # .gitignore # package-lock.json
Getting mixed results with the tests, some versions of WP pass, others fail. I suspect there are some markup changes that will need to be accounted for. |
Note that #1038 documents the additional tests needed that otherwise were not added in this PR |
d9ea8b1
to
9d861de
Compare
# Conflicts: # package-lock.json
The existing tests on this branch are now passing so I will merge this in to restore what we can. |
Description of the Change
DistributedPostTest.php
EditorBlocksTest.php
ExternalConnectionCreateTest.php --> external-connection.test.js
InternalPullTest.php --> internal-pull.test.js
InternalPushTest.php --> internal-push.test.js
LinkUnlinkTest.php
OembedTest.php
PushMenuTest.php
SettingsTest.php --> settings.test.js
How to test the Change
Changelog Entry
Credits
Props @cadic
Checklist: