Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate WPAcceptance tests to Cypress #941

Merged
merged 34 commits into from
May 29, 2023

Conversation

cadic
Copy link
Contributor

@cadic cadic commented Sep 19, 2022

Description of the Change

DistributedPostTest.php

  • testDistributedCount
  • testDistributedFrom

EditorBlocksTest.php

  • addContentToTestPost
  • testBlocksNetworkPushedContent
  • testBlocksNetworkPulledContent
  • testBlocksExternalPushedContent
  • testBlocksExternalPulledContent

ExternalConnectionCreateTest.php --> external-connection.test.js

  • testCreateExternalConnection

InternalPullTest.php --> internal-pull.test.js

  • testPostShowingPerStatus
  • testPullPost
  • testSkipPost
  • testSearchMultipleWordsDuringPull

InternalPushTest.php --> internal-push.test.js

  • testPushDraftPost
  • testPushPublishPost
  • testPushDataSync

LinkUnlinkTest.php

  • testUnlinkPublishPost

OembedTest.php

  • testOembedNetworkPushedContent
  • testOembedNetworkPulledContent
  • testOembedExternalPushedContent
  • testOembedExternalPulledContent

PushMenuTest.php

  • testMenuItemHover
  • testConnectionCrossOutOnPush
  • testSelectConnection

SettingsTest.php --> settings.test.js

  • testSettingsSave
  • testAuthorBylineSetting

How to test the Change

Changelog Entry

Changed - Migrate WPAcceptance tests to Cypress

Credits

Props @cadic

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Sorry, something went wrong.

@cadic cadic self-assigned this Sep 19, 2022
@@ -49,9 +49,6 @@ jobs:
npx wp-env run cli "wp core version"
npx wp-env run cli "php --version"

- name: Convert to multisite
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See tests/bin/initialize.sh

@cadic cadic changed the title Migrate WPAcceptance to Cypress Migrate WPAcceptance tests to Cypress Sep 23, 2022
Sidsector9
Sidsector9 previously approved these changes Oct 1, 2022
Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this @cadic! LGTM 👍

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@cadic
Copy link
Contributor Author

cadic commented Oct 3, 2022

@Sidsector9 this is an unfinished work, still needs some tests to be migrated

@iamdharmesh iamdharmesh self-assigned this Nov 4, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jeffpaul jeffpaul added this to the 2.0.0 milestone Feb 23, 2023
@jeffpaul
Copy link
Member

@peterwilsoncc FYI on this in-progress work here that we'll want to ensure gets wrapped before v2 is released so we can ensure these run & validate the refactoring work you're leading

@peterwilsoncc
Copy link
Collaborator

I'll resolve the merge conflicts on this and merge the progress if everything is working as expected.

Verified

This commit was signed with the committer’s verified signature.
peterwilsoncc Peter Wilson
# Conflicts:
#	.gitignore
#	package-lock.json
@peterwilsoncc
Copy link
Collaborator

Getting mixed results with the tests, some versions of WP pass, others fail.

I suspect there are some markup changes that will need to be accounted for.

@jeffpaul jeffpaul mentioned this pull request Mar 22, 2023
12 tasks
@jeffpaul
Copy link
Member

Note that #1038 documents the additional tests needed that otherwise were not added in this PR

@peterwilsoncc peterwilsoncc force-pushed the tests/migrate-wpacc-cypress branch from d9ea8b1 to 9d861de Compare March 23, 2023 00:53
@peterwilsoncc
Copy link
Collaborator

Getting mixed results with the tests, some versions of WP pass, others fail.

This should be resolved by #1056 for #1055.

@peterwilsoncc
Copy link
Collaborator

The existing tests on this branch are now passing so I will merge this in to restore what we can.

@peterwilsoncc peterwilsoncc marked this pull request as ready for review May 29, 2023 22:57
@peterwilsoncc peterwilsoncc requested review from jeffpaul and a team as code owners May 29, 2023 22:57
@peterwilsoncc peterwilsoncc merged commit 79ffd56 into develop May 29, 2023
@peterwilsoncc peterwilsoncc deleted the tests/migrate-wpacc-cypress branch May 29, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants