Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translatability of strings. #935

Merged
merged 12 commits into from
Sep 4, 2022
Merged

Conversation

peterwilsoncc
Copy link
Collaborator

@peterwilsoncc peterwilsoncc commented Aug 31, 2022

Description of the Change

This PR modifies numerous strings that are unable to be translated:

  • concatenations are replaced with placeholders
  • singular/plurals use _n and related functions
  • contexts added where appropriate

See #267

How to test the Change

Changelog Entry

Fixed - Updated numerous strings to improve their translatability.

Credits

Props @helen, @peterwilsoncc, @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@peterwilsoncc peterwilsoncc self-assigned this Aug 31, 2022
@peterwilsoncc peterwilsoncc added this to the 2.0.0 milestone Aug 31, 2022
@peterwilsoncc peterwilsoncc force-pushed the fix/267-translation-bugs branch from 14f55f3 to acdb1e0 Compare August 31, 2022 04:29
@peterwilsoncc peterwilsoncc marked this pull request as ready for review September 1, 2022 04:07
@peterwilsoncc peterwilsoncc requested review from a team and Sidsector9 and removed request for a team September 1, 2022 04:07
@peterwilsoncc peterwilsoncc merged commit 6a94d68 into develop Sep 4, 2022
@peterwilsoncc peterwilsoncc deleted the fix/267-translation-bugs branch September 4, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants