Bump WordPress and PHP minimum #917

peterwilsoncc · 2022-08-03T03:24:24Z

Description of the Change

Bump WordPress minimum to 5.7
Bump PHP minimum to 7.4

Closes #905, Closes #925

How to test the Change

Changelog Entry

Changed - Now requires PHP 7.4 or later and WordPress 5.7 or later.

Credits

Props @peterwilsoncc, @vikrampm1, @iamdharmesh.

Checklist:

I agree to follow this project's Code of Conduct.
I have updated the documentation accordingly.
I have added tests to cover my change.
All new and existing tests pass.

peterwilsoncc · 2022-08-03T04:02:22Z

distributor.php

@@ -55,14 +55,29 @@ function( $class ) {
 );

 /**
- * Require PHP version 5.6 - throw an error if the plugin is activated on an older version.
+ * Require PHP 7.4+, WP 5.7+ - throw an error if the plugin is activated on an older version.
 */
 register_activation_hook(


These changes prevent activation of the plugin on unsupported versions of WP, PHP.

There is now the small risk a site will have an active plugin and update to a version it no longer supports. How have we handled that in the past?

So I was trying to find a version of this in our plugins and couldn't quite remember where it's at but what we've done in the past is have some code in the main plugin file (so this file in this case) that checks if our requirements are met and if not, output an admin notice and stop execution of the plugin. Not our plugin but here's a similar approach in a Woo plugin: https://github.com/woocommerce/google-listings-and-ads/blob/develop/google-listings-and-ads.php#L41 and https://github.com/woocommerce/google-listings-and-ads/blob/develop/src/Internal/Requirements/VersionValidator.php#L22

In 6187c56 I've added a first pass at showing a notice if the plugin fails to meet minimum version requirements.

Honestly, it seems like a lot for something that ought to be quite minor but I am not sure if there is much that can be done about that. For this to work, the plugin's main file will always need to be compatible with earlier versions of WP/PHP. The up-to-date code will need to come later.

Should I move some of the bootstrapping code so distributor.php can focus on activation & a bootstrapper can focus on bootstrapping?

…sions.

# Conflicts: # readme.txt

peterwilsoncc · 2022-08-17T04:25:34Z

includes/syndicated-post-ui.php

-			$post = isset( $_GET['post'] ) ? get_post( (int) $_GET['post'] ) : false; // @codingStandardsIgnoreLine Nonce not required
-
-			if ( $post && ! \Distributor\Utils\is_using_gutenberg( $post ) ) {
-				add_action( 'do_meta_boxes', __NAMESPACE__ . '\replace_revisions_meta_box', 10, 3 );
-				add_action( 'add_meta_boxes', __NAMESPACE__ . '\add_revisions_meta_box' );
-			}
+			add_action( 'do_meta_boxes', __NAMESPACE__ . '\replace_revisions_meta_box', 10, 3 );
+			add_action( 'add_meta_boxes', __NAMESPACE__ . '\add_revisions_meta_box' );


The is_using_gutenberg() function call is moved to the do_meta_boxes hook where it is used. This ensures all the editor functions are defined before attempting to use them. Specifically, in this instance, use_block_editor_for_post_type().

Expand explanation of internal helper to document why it exists.

…ype` is defined.

Instead of reproducing the function (including the final filter) call the function if it exists. Otherwise go through the polyfill steps.

# Conflicts: # distributor.php

iamdharmesh

Thanks a lot for the great work here @peterwilsoncc, Code looks good to me just want you to check on the notes below.

I am getting 404 for admin.min.css
I think we should also add minimum requirements in the plugin header of the plugin’s main PHP file as well. Since WordPress 5.8 plugin readme files are not parsed for requirements. This means that headers Requires PHP and Requires at least are going to be parsed from plugin’s main PHP file.

Thanks

peterwilsoncc · 2022-08-22T00:10:13Z

@iamdharmesh I've added the requirements to the main plugin file in c1c93fb

You'll need to run npm i; npm run build in your command line for the css files to be generated.

iamdharmesh · 2022-08-22T04:29:09Z

Thanks for adding requirements to the main plugin file @peterwilsoncc.

You'll need to run npm i; npm run build in your command line for the css files to be generated.

Yes, I am already doing this, but it seems the URL to load CSS file is wrong. it is .../distributor/includes/dist/css/... instead of .../distributor/dist/css/....

Thanks

includes/bootstrap.php

Co-authored-by: Dharmesh Patel <[email protected]>

peterwilsoncc · 2022-08-22T05:33:27Z

it is .../distributor/includes/dist/css/... instead of .../distributor/dist/css/....

Sorry, I missed that in the screen shot.

I've merged in your chagne

iamdharmesh

Thanks for the changes @peterwilsoncc. All looks good to me now. 🚀

Thanks for your amazing work here.

README.md

Co-authored-by: Darin Kotter <[email protected]>

peterwilsoncc added 5 commits August 3, 2022 13:13

Update readme files with minimum supported versions.

f52af91

Update workflows using PHP or WP versions.

04a1580

Remove redundent applications password plugin.

5db745c

Prevent activation on old versions.

f6aaf1e

Update PHP versions in docunit file.

725da61

peterwilsoncc commented Aug 3, 2022

View reviewed changes

Use two letter version numbers for version compare.

a3bcc0a

peterwilsoncc force-pushed the fix/requirement-bump branch from 0d61a5f to a3bcc0a Compare August 3, 2022 04:36

peterwilsoncc added 2 commits August 3, 2022 14:42

wp_is_application_passwords_available() exists in all supported ver…

1723f1b

…sions.

Simplify is_using_gutenberg() for WP5.7+ support only.

3437cc2

peterwilsoncc force-pushed the fix/requirement-bump branch from 1fb3610 to 3437cc2 Compare August 3, 2022 05:57

peterwilsoncc mentioned this pull request Aug 6, 2022

Remove application passwords dependency #925

Closed

1 task

peterwilsoncc added 7 commits August 16, 2022 13:35

Merge branch 'develop' into fix/requirement-bump

958538f

# Conflicts: # readme.txt

Add mocked functions required for updated Gutenberg detection.

7ab4015

Show notice if version requirements fail.

6187c56

Remove note about application password merge.

4dbb6e3

Refer to application passwords feature rather than plugin.

856f9fb

Improve strings for minimum requirements.

135e1d4

Move bootstrapping to dedicated file.

66008eb

peterwilsoncc commented Aug 17, 2022

View reviewed changes

peterwilsoncc added 2 commits August 17, 2022 15:01

Use internal helper function to determine if post type is supported.

ba86310

Expand explanation of internal helper to document why it exists.

Delay calling is_using_gutenberg until `use_block_editor_for_post_t…

2a7eed0

…ype` is defined.

peterwilsoncc force-pushed the fix/requirement-bump branch from ca74e75 to 2a7eed0 Compare August 17, 2022 05:01

peterwilsoncc added 2 commits August 17, 2022 15:26

Add sniff for main file’s bespoke compatibility requirements.

0026bd1

Document main plugin file’s bespoke compatibility requirements.

9415023

peterwilsoncc force-pushed the fix/requirement-bump branch from 302e302 to 9415023 Compare August 17, 2022 05:34

peterwilsoncc added 3 commits August 18, 2022 11:23

Remove application password plugin reference in admin.

3fef859

Include authentication endpoint in distributor endpoint.

7f53170

Defer to use_block_editor_for_post_type() if it exists.

8ff14ee

Instead of reproducing the function (including the final filter) call the function if it exists. Otherwise go through the polyfill steps.

peterwilsoncc marked this pull request as ready for review August 18, 2022 05:46

peterwilsoncc requested review from a team and iamdharmesh and removed request for a team August 18, 2022 05:46

jeffpaul added this to the 2.0.0 milestone Aug 18, 2022

peterwilsoncc added 2 commits August 19, 2022 09:58

Merge branch 'develop' into fix/requirement-bump

74a5c78

# Conflicts: # distributor.php

Avoid deprecated gutenberg_get_jed_locale_data().

7be0237

peterwilsoncc force-pushed the fix/requirement-bump branch from d4fa229 to 7be0237 Compare August 19, 2022 01:53

iamdharmesh reviewed Aug 19, 2022

View reviewed changes

peterwilsoncc added 2 commits August 22, 2022 10:07

Add minimum requirements to main plugin file.

c1c93fb

Update package-lock file for npm 8.x.

9dfd669

iamdharmesh reviewed Aug 22, 2022

View reviewed changes

includes/bootstrap.php Outdated Show resolved Hide resolved

Update CSS directory.

4af2c14

Co-authored-by: Dharmesh Patel <[email protected]>

Fix minimum requirements in main plugin file.

4d8679b

iamdharmesh previously approved these changes Aug 22, 2022

View reviewed changes

dkotter reviewed Aug 23, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

dkotter previously approved these changes Aug 23, 2022

View reviewed changes

jeffpaul assigned peterwilsoncc Aug 23, 2022

Improve notes about local environment.

e3c3999

Co-authored-by: Darin Kotter <[email protected]>

peterwilsoncc dismissed stale reviews from dkotter and iamdharmesh via e3c3999 August 23, 2022 22:35

dkotter approved these changes Aug 23, 2022

View reviewed changes

dkotter merged commit 014c3c9 into develop Aug 23, 2022

dkotter deleted the fix/requirement-bump branch August 23, 2022 22:48

peterwilsoncc mentioned this pull request Sep 27, 2022

Fix undefined variable localizing gutenberg-syndicated-post. #945

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump WordPress and PHP minimum #917

Bump WordPress and PHP minimum #917

peterwilsoncc commented Aug 3, 2022 •

edited

Loading

peterwilsoncc Aug 3, 2022

dkotter Aug 3, 2022

peterwilsoncc Aug 16, 2022

peterwilsoncc Aug 17, 2022 •

edited

Loading

iamdharmesh left a comment

peterwilsoncc commented Aug 22, 2022

iamdharmesh commented Aug 22, 2022

peterwilsoncc commented Aug 22, 2022

iamdharmesh left a comment

Bump WordPress and PHP minimum #917

Bump WordPress and PHP minimum #917

Conversation

peterwilsoncc commented Aug 3, 2022 • edited Loading

Description of the Change

How to test the Change

Changelog Entry

Credits

Checklist:

peterwilsoncc Aug 3, 2022

Choose a reason for hiding this comment

dkotter Aug 3, 2022

Choose a reason for hiding this comment

peterwilsoncc Aug 16, 2022

Choose a reason for hiding this comment

peterwilsoncc Aug 17, 2022 • edited Loading

Choose a reason for hiding this comment

iamdharmesh left a comment

Choose a reason for hiding this comment

peterwilsoncc commented Aug 22, 2022

iamdharmesh commented Aug 22, 2022

peterwilsoncc commented Aug 22, 2022

iamdharmesh left a comment

Choose a reason for hiding this comment

peterwilsoncc commented Aug 3, 2022 •

edited

Loading

peterwilsoncc Aug 17, 2022 •

edited

Loading