Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/827 Version 2.4.0 upgrade for actions/checkout #828

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Conversation

faisal-alvi
Copy link
Member

Description of the Change

This PR upgrades the actions/checkout version to 2.4.0.

Verification Process

Validate that GitHub Actions work as necessary.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes #827.

Changelog Entry

Fix - Workflow files using vulnerable action actions/checkout

@faisal-alvi faisal-alvi requested a review from a team December 21, 2021 11:49
@faisal-alvi faisal-alvi self-assigned this Dec 21, 2021
@faisal-alvi faisal-alvi requested review from cadic and removed request for a team December 21, 2021 11:49
Copy link
Contributor

@cadic cadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faisal-alvi the code looks good, but the PR Description contains a link to non-existing issue (827)

@jeffpaul jeffpaul added this to the 1.7.0 milestone Dec 21, 2021
@faisal-alvi
Copy link
Member Author

faisal-alvi commented Dec 22, 2021

@cadic - it's weird! there was an issue at #827 but now it's not there! Github Bot also recorded it here.

image removed intentionally

@jeffpaul
Copy link
Member

@faisal-alvi as I noted in my now-deleted comment (guessing someone at GitHub deleted those issues as they were security-related issues submitted publicly) we'll also want to check for the other locations to update as well. Please ensure additional PRs are opened for those.

@jeffpaul jeffpaul merged commit a56460b into develop Dec 23, 2021
@jeffpaul jeffpaul deleted the fix/827 branch December 23, 2021 19:44
@jeffpaul jeffpaul modified the milestones: 1.7.0, 1.6.8 Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants