Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Uninstall distributor #540
base: develop
Are you sure you want to change the base?
Fix: Uninstall distributor #540
Changes from 50 commits
863ab95
00b3768
27d45b5
b5e16da
69ff81e
c2fd377
620f8ef
0f8eaec
07d1d3b
f79234e
4d1dfad
fcd4299
ab9e708
1f5caf0
f8b5fb9
e62c579
74ceb30
034891e
65a69b0
3d02f1d
543be5e
910ff84
7c7856f
12c1485
bb7df21
0ede961
71fdbd5
d9b4b57
a149f14
09f07b5
30d31b4
76eb110
8395719
d10a2f7
38c8d15
fdae543
393ccdb
2890ce9
2506645
45786f1
1188c05
27ab735
2551260
9854aed
ff2b790
f2f9b73
e0530b9
b96e12a
ef103dd
7826ef2
4f480a7
6923237
15e060d
39830c6
548c8a1
2aa68df
8444087
49aa191
64621e9
a46f0b5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File needs to be added to this block of code
distributor/webpack.config.release.js
Lines 11 to 29 in c27d99a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is being called with the option ID but the cache uses the option_name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is using the option ID for the cache names, but it's cached using the pattern
$network_id:$option_name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is using
meta_id
from thesitemeta
table, do you mean we should pass$network_id:{sitemeta.meta_key}
? Where we can usesitemeta.site_id
as a$network_id
. So something like this?:wp_cache_delete_multiple( [Array of {sitemeta.site_id:sitemeta.meta_key}], 'site-options' );