Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use GITHUB_OUTPUT envvar instead of set-output command #1178

Merged
merged 8 commits into from
Jul 5, 2024
Merged

ci: Use GITHUB_OUTPUT envvar instead of set-output command #1178

merged 8 commits into from
Jul 5, 2024

Conversation

arunsathiya
Copy link
Contributor

save-state and set-output commands used in GitHub Actions are deprecated and GitHub recommends using environment files.

This PR updates the usage of set-output to $GITHUB_OUTPUT

Instructions for envvar usage from GitHub docs:

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter

@arunsathiya arunsathiya requested a review from jeffpaul as a code owner January 13, 2024 20:38
@jeffpaul jeffpaul added this to the 2.1.0 milestone Jan 16, 2024
@jeffpaul jeffpaul requested review from a team and Sidsector9 and removed request for jeffpaul and a team January 16, 2024 19:15
@jeffpaul jeffpaul requested a review from iamdharmesh June 13, 2024 15:47
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR and your contribution. LGTM.

@iamdharmesh
Copy link
Member

Note: E2E tests are failing but not related to this PR.

@iamdharmesh iamdharmesh merged commit defa95a into 10up:develop Jul 5, 2024
9 of 16 checks passed
@dkotter dkotter modified the milestones: 2.1.0, 2.0.5 Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants