-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy .htaccess file when initilizing multisite on test container. #1143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious on why this is needed? I know we already have an npm script that copies the htaccess file before tests are run (see https://github.com/10up/distributor/blob/develop/.github/workflows/cypress.yml#L100 and https://github.com/10up/distributor/blob/develop/package.json#L63) so wondering if that's not working?
@dkotter It's for running the tests locally rather than in CI. It allows devs to run At the moment |
Okay, I guess the question I have then is should we remove the copying of the htaccess file from the |
86fb50e
to
7f35150
Compare
7f35150
to
9b7c613
Compare
Description of the Change
Ensures the htaccess file is copied when the test container's Docker environment is converted to multisite.
Closes #
How to test the Change
npm run env:destroy
to reset the environmentnpm run env:start
Changelog Entry
Credits
Props @peterwilsoncc, @theskinnyghost, @dkotter.
Checklist: