Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/missing props #1131

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Fix/missing props #1131

merged 2 commits into from
Sep 6, 2023

Conversation

jeffpaul
Copy link
Member

@jeffpaul jeffpaul commented Sep 6, 2023

Description of the Change

During the 2.0.0 release we missed a credit in #1118 (comment), so this PR adds that to the changelog and credits files as well as adds the missing release date to the changelog file.

How to test the Change

Review changes using a markdown previewer as these are docs-only changes and non-functional changes.

Changelog Entry

Changed - Documentation updates.

Credits

Props @jeffpaul.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 2.0.1 milestone Sep 6, 2023
@jeffpaul jeffpaul requested a review from a team as a code owner September 6, 2023 14:57
@jeffpaul jeffpaul self-assigned this Sep 6, 2023
@jeffpaul jeffpaul removed the request for review from a team September 6, 2023 14:57
Copy link
Collaborator

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@peterwilsoncc peterwilsoncc merged commit d4578e3 into develop Sep 6, 2023
17 checks passed
@peterwilsoncc peterwilsoncc deleted the fix/missing-props branch September 6, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants