Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing E2E tests #1128

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Fix failing E2E tests #1128

merged 4 commits into from
Sep 6, 2023

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Sep 5, 2023

Description of the Change

WordPress 6.3 changed how the Block Editor is loaded by default (loaded in an iframe now) and this causes issues with our E2E tests. This PR fixes those issues in the following ways:

  1. Update to the latest version of the @10up/cypress-wp-utils package and use the new getBlockEditor helper command from that. This version contains multiples fixes for WP 6.3
  2. Update to the newest version of the @wordpress/env package in the v5 release. Originally wanted to update this to the latest overall version but ran into some issues that will need some more time to explore
  3. Update Cypress to v13
  4. Set the chromeWebSecurity Cypress config to false, allowing Cypress to more easily interact with iframes

Closes #1125

How to test the Change

Ensure all E2E tests pass on this PR

Changelog Entry

Changed - Update from Cypress v10 to v13
Fixed - Ensure our E2E tests pass on WordPress 6.3

Credits

Props @dkotter, @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter self-assigned this Sep 5, 2023
@dkotter dkotter marked this pull request as ready for review September 5, 2023 20:57
@dkotter dkotter requested review from jeffpaul and a team as code owners September 5, 2023 20:57
@dkotter dkotter requested review from peterwilsoncc and removed request for a team and jeffpaul September 5, 2023 20:57
Copy link
Collaborator

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Tests suite passes both on GH and on local dev environment.

@peterwilsoncc peterwilsoncc added this to the 2.0.1 milestone Sep 6, 2023
@peterwilsoncc peterwilsoncc merged commit 9da9876 into develop Sep 6, 2023
@peterwilsoncc peterwilsoncc deleted the fix/e2e-tests branch September 6, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Cypress to version 13
3 participants