-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if the post is distributed, and if it is apply the author filter #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggutenberg
changed the title
Check if the post is distributed, and if it is return the original site
Check if the post is distributed, and if it is return the original site as author
Mar 20, 2023
ggutenberg
changed the title
Check if the post is distributed, and if it is return the original site as author
Check if the post is distributed, and if it is apply the author filter
Mar 21, 2023
ggutenberg
requested review from
dkotter and
peterwilsoncc
and removed request for
a team
March 21, 2023 15:20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well, thanks Garth.
I've made one suggestion inline.
peterwilsoncc
approved these changes
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, checked on a variety of block and classic themes.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
If an author ID is specified in a call to
get_the_author_meta()
, instead of returning the specified author blindly, we are also checking the post itself and whether or not it was distributed. If it was, we apply theget_the_author_display_name
andget_the_author_user_url
filters as usual.Closes #1015
How to test the Change
Make sure you're using a theme that supports the block editor for this like Twenty Twenty-Two, as the Classic editor themes don't have an issue.
Override Author Byline
is checked.Override Author Byline
in the Distributor settings.Changelog Entry
Credits
Props @ggutenberg
Checklist: