-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak: add new action hooks and deprecated existing #1024
Conversation
c87ecd4
to
6bede2b
Compare
While checking existing action/filters hooks, I notice the following things:
Let me know if you want me to take action on the same pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor notes inline.
includes/classes/ExternalConnections/WordPressExternalConnection.php
Outdated
Show resolved
Hide resolved
…on.php Co-authored-by: Peter Wilson <[email protected]>
Co-authored-by: Peter Wilson <[email protected]>
@peterwilsoncc I merged your suggestion and replied to your question. This pull request is ready to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, let's figure out the other hooks you mentioned on a follow up PR.
Description of the Change
As discussed, I deprecated
dt_push_post
and added two action hooks,dt_push_external_post
anddt_push_network_post
.Closes #123
How to test the Change
debug.log
when usedt_push_post
action hookdt_push_external_post
anddt_push_network_post
action hooks should not cause any issue when useChangelog Entry
Credits
Props @dkotter @peterwilsoncc @dhanendran
Checklist: