Added selected connection count #1020

roshniahuja · 2023-02-21T10:03:10Z

Fixes for issue #592

Description of the Change

Issue mentioned URL - #592

Added selected connection count

Closes

How to test the Change

To test this feature - Need to select connection from dropdown and it will increase count in Selected connection

Changelog Entry

Added - Show count of selected connections in Push menu.

Credits

Props @roshniahuja

Checklist:

I agree to follow this project's Code of Conduct.
I have updated the documentation accordingly.
I have added tests to cover my change.
All new and existing tests pass.

roshniahuja · 2023-02-22T09:27:19Z

@peterwilsoncc,

I have few ESLint errors and I already tried to resolve by installing ESLint and Prettier ESLint extension but still nothing works so If anyone can take a look then it will be appreciated.

peterwilsoncc · 2023-02-23T02:07:22Z

@roshniahuja I've pushed 22a5031 which fixes the linting errors.

Getting the lints set up in your IDE can be luck as much as anything else. If you use VS Code, I can share my extensions with you if you reach out via Slack.

peterwilsoncc

A couple of inline notes about consistency with layout/spacing within the brackets.

I'm wondering if it would be better to use the string Selected connections (%d) to ensure the strings are translatable in to all language formats.

The HTML could become:

<header class="with-selected">
	<span class="selected-connections-text"><?php esc_html_e( 'Selected connections', 'distributor' ); ?></span>
	<button class="button button-link selectno-connections unavailable"><?php esc_html_e( 'Clear', 'distributor' ); ?></button>
</header>

And the text in selected-connections-text replaced in full via the JavaScript. @ravinderk, do you have an opinion on what would be best?

assets/js/push.js

peterwilsoncc

This looks great, thank you!

One minor note about translator comments for _n but otherwise it looks good.

peterwilsoncc · 2023-03-03T03:50:12Z

assets/js/push.js

@@ -580,7 +581,19 @@ jQuery( window ).on( 'load', () => {
 				deleteNode.parentNode.removeChild( deleteNode );

 				delete selectedConnections[ type + id ];
-
+				selectedText = sprintf(
+					/* translators: 1) Selected connection content singular name. 2) Selected connection content plural name. */


Suggested change

/* translators: 1) Selected connection content singular name. 2) Selected connection content plural name. */

/* translators: %d: Number of selected connections. */

For _n translator notes are a little odd, the comment applies to both strings as the placeholders need to be identical.

peterwilsoncc · 2023-03-03T03:51:25Z

assets/js/push.js

@@ -602,6 +615,19 @@ jQuery( window ).on( 'load', () => {
 				selectedConnections[ type + id ] = dtConnections[ type + id ];

 				const element = event.currentTarget.cloneNode( true );
+				selectedText = sprintf(
+					/* translators: 1) Selected connection content singular name. 2) Selected connection content plural name. */


Suggested change

/* translators: 1) Selected connection content singular name. 2) Selected connection content plural name. */

/* translators: %d: Number of selected connections. */

Comment Updated.

peterwilsoncc · 2023-03-03T03:51:41Z

assets/js/push.js

@@ -660,6 +686,19 @@ jQuery( window ).on( 'load', () => {

 					element.appendChild( removeLink );
 					element.classList = 'added-connection';
+					selectedText = sprintf(
+						/* translators: 1) Selected connection content singular name. 2) Selected connection content plural name. */


Suggested change

/* translators: 1) Selected connection content singular name. 2) Selected connection content plural name. */

/* translators: %d: Number of selected connections. */

peterwilsoncc · 2023-03-03T03:51:59Z

assets/js/push.js

@@ -691,6 +730,19 @@ jQuery( window ).on( 'load', () => {
 					);

 				delete selectedConnections[ type + id ];
+				selectedText = sprintf(
+					/* translators: 1) Selected connection content singular name. 2) Selected connection content plural name. */


Suggested change

/* translators: 1) Selected connection content singular name. 2) Selected connection content plural name. */

/* translators: %d: Number of selected connections. */

peterwilsoncc · 2023-03-03T03:52:12Z

assets/js/push.js

@@ -721,7 +773,18 @@ jQuery( window ).on( 'load', () => {
 			const id = event.currentTarget.getAttribute( 'data-connection-id' );

 			delete selectedConnections[ type + id ];
-
+			selectedText = sprintf(
+				/* translators: 1) Selected connection content singular name. 2) Selected connection content plural name. */


Suggested change

/* translators: 1) Selected connection content singular name. 2) Selected connection content plural name. */

/* translators: %d: Number of selected connections. */

peterwilsoncc

Looks good to me, thank you!

Added selected connection count

b65c4f9

roshniahuja requested a review from a team as a code owner February 21, 2023 10:03

roshniahuja requested review from Sidsector9 and removed request for a team February 21, 2023 10:03

roshniahuja mentioned this pull request Feb 21, 2023

Show count of selected connections in Push menu #592

Closed

1 task

roshniahuja added 10 commits February 21, 2023 17:21

fixed eslint errors

c5edbc7

fixed eslint errors

8319894

fixed eslint errors

4cf52a4

Tried to fix eslint errors

9a28de4

Tried to fix eslint errors

13d07da

Fixed Eslint errors

d1169db

Fixed Eslint errors

6d01813

Fixed Eslint errors

2627446

Fixed Eslint errors

9d15f42

revert back the changes

eaa8af0

roshniahuja added the help wanted label Feb 22, 2023

roshniahuja assigned peterwilsoncc Feb 22, 2023

peterwilsoncc added 2 commits February 23, 2023 13:01

CS: Fix prettier issues.

22a5031

Merge branch 'develop' into feature/connection-count

c72d009

peterwilsoncc reviewed Feb 23, 2023

View reviewed changes

assets/js/push.js Outdated Show resolved Hide resolved

assets/js/push.js Outdated Show resolved Hide resolved

assets/js/push.js Outdated Show resolved Hide resolved

jeffpaul linked an issue Feb 23, 2023 that may be closed by this pull request

Show count of selected connections in Push menu #592

Closed

1 task

jeffpaul added this to the 2.0.0 milestone Feb 23, 2023

roshniahuja added 6 commits February 28, 2023 22:27

Added translatable string

3f6b39e

Changed variable name for translatable string

5a49438

Resolved Eslint errors

2a807bc

Resolved Eslint errors

94514d0

Resolved Eslint errors

6eb5fd6

Revert back the changes for Eslint errors

9628526

roshniahuja added 12 commits March 1, 2023 15:20

Resolved Eslint errors

7e895e3

Resolved Eslint errors

1f3af81

Resolved Eslint errors

ee43fb9

Resolved Eslint errors

a508e76

Resolved Eslint errors

7dcb4a0

CS: Fix prettier issues.

393b8b3

CS: Fix prettier issues.

f160de5

CS: Fix prettier issues.

dd3d8e8

CS: Fix prettier issues.

97a6e76

CS: Fix prettier issues.Removed extra space

484e883

CS: Fix prettier issues

fa3e6b2

Merge branch 'develop' into feature/connection-count

9814341

roshniahuja requested a review from peterwilsoncc March 2, 2023 08:49

roshniahuja added needs:code-review This requires code review. and removed help wanted labels Mar 2, 2023

peterwilsoncc reviewed Mar 3, 2023

View reviewed changes

changed comment for translator

e9ae049

roshniahuja requested a review from peterwilsoncc March 6, 2023 16:28

peterwilsoncc approved these changes Mar 7, 2023

View reviewed changes

peterwilsoncc merged commit 7744348 into develop Mar 7, 2023

peterwilsoncc deleted the feature/connection-count branch March 7, 2023 03:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added selected connection count #1020

Added selected connection count #1020

roshniahuja commented Feb 21, 2023 •

edited by jeffpaul

Loading

roshniahuja commented Feb 22, 2023

peterwilsoncc commented Feb 23, 2023

peterwilsoncc left a comment

peterwilsoncc left a comment

peterwilsoncc Mar 3, 2023

peterwilsoncc Mar 3, 2023

roshniahuja Mar 6, 2023

peterwilsoncc Mar 3, 2023

peterwilsoncc Mar 3, 2023

peterwilsoncc Mar 3, 2023

peterwilsoncc left a comment

	/* translators: 1) Selected connection content singular name. 2) Selected connection content plural name. */
	/* translators: %d: Number of selected connections. */

Added selected connection count #1020

Added selected connection count #1020

Conversation

roshniahuja commented Feb 21, 2023 • edited by jeffpaul Loading

Description of the Change

How to test the Change

Changelog Entry

Credits

Checklist:

roshniahuja commented Feb 22, 2023

peterwilsoncc commented Feb 23, 2023

peterwilsoncc left a comment

Choose a reason for hiding this comment

peterwilsoncc left a comment

Choose a reason for hiding this comment

peterwilsoncc Mar 3, 2023

Choose a reason for hiding this comment

peterwilsoncc Mar 3, 2023

Choose a reason for hiding this comment

roshniahuja Mar 6, 2023

Choose a reason for hiding this comment

peterwilsoncc Mar 3, 2023

Choose a reason for hiding this comment

peterwilsoncc Mar 3, 2023

Choose a reason for hiding this comment

peterwilsoncc Mar 3, 2023

Choose a reason for hiding this comment

peterwilsoncc left a comment

Choose a reason for hiding this comment

roshniahuja commented Feb 21, 2023 •

edited by jeffpaul

Loading