Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap checker added #97

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Sitemap checker added #97

merged 2 commits into from
Jun 28, 2023

Conversation

jayedul
Copy link
Contributor

@jayedul jayedul commented Jun 20, 2023

Description of the Change

Sitemap checker command added

Closes #92

How to test the Change

  • Install this library as NPM package
  • Write cy.checkSitemap() anywhere in a test script
  • Run e2e test
  • Make sure it throws error if sitemap.xml doesn't exist, otherwise logs Sitemap exists.

Changelog Entry

Added - Sitemap checker command added

Credits

Props @jayedul, @jeffpaul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jayedul jayedul self-assigned this Jun 20, 2023
@jeffpaul jeffpaul added this to the 0.2.0 milestone Jun 22, 2023
@jeffpaul jeffpaul requested review from a team and ravinderk and removed request for a team June 22, 2023 21:47
@jayedul jayedul marked this pull request as ready for review June 26, 2023 07:23
@jayedul jayedul requested a review from a team as a code owner June 26, 2023 07:23
@jayedul
Copy link
Contributor Author

jayedul commented Jun 26, 2023

Well, I see this PR has been approved already despite some e2e tests failed that are actually unrelated to this PR. So I've marked this as ready for review.

@jeffpaul jeffpaul merged commit a6bb77d into develop Jun 28, 2023
@jeffpaul jeffpaul deleted the feature/92 branch June 28, 2023 16:06
github-actions bot pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add check that sitemap exists
3 participants