Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create term test #82

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Fix create term test #82

merged 1 commit into from
Dec 15, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented Dec 12, 2022

Description of the Change

Remove checking for the notice text when testing createTerm command, the notice selector vary from version to versin, does not exist in 5.7 at all and does not makes any sense in the test scenario since we are also checking that the term was added to terms table.

Closes #81

How to test the Change

Changelog Entry

Fixed - createTerm command tests

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@cadic cadic added this to the 0.1.0 milestone Dec 12, 2022
@cadic cadic requested a review from a team December 12, 2022 08:10
@cadic cadic self-assigned this Dec 12, 2022
@cadic cadic requested review from Sidsector9 and removed request for a team December 12, 2022 08:10
@cadic cadic changed the title Fix create term test" Fix create term test Dec 12, 2022
Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @cadic , LGTM 👍

@cadic cadic merged commit 6a1b2e1 into trunk Dec 15, 2022
@cadic cadic deleted the fix/81-tests branch December 15, 2022 11:07
github-actions bot pushed a commit that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Create term" test fails with WP minimum 5.7
2 participants