Fix: createTerm issue with custom hierarchical taxonomy #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
dinhtungdu
added
type:bug
3 tasks
cadic
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Great catch, @dinhtungdu and thank you for the fix!
The current PR is LGTM!
I have created separate issue to cover this with tests #52
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2022
Fix: createTerm issue with custom hierarchical taxonomy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR fix the issue with custom hierarchical taxonomy when using
cy.createTermto create the first taxonomy. The parent dropdown exists in HTML but isn't visible. This causes the timeout issue as described in the #50.Closes #50
Checklist:
Changelog Entry
Credits
Props @dinhtungdu