-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair E2E tests #103
Repair E2E tests #103
Conversation
This reverts commit 1096b0d.
80a1a50
to
83d0126
Compare
@jeffpaul I don't know if I should specifically ping you about this. I managed to fix the E2E tests by ignoring a CORS related error and by running them on Chrome (they were failing on Electron, objections?) but now I'm facing another test failure with WP trunk version. I consistently get an error like
when opening the editor using Cypress, something I don't get when loading the exact same site using my Chrome. I don't know how to proceed, any suggestions? |
Hi @kmgalanakis, Thank you for the PR.
This is a known issue with WP 6.3 and we have an open issue for it #104. It should be fixed separately from this PR. So, we can proceed here with ignoring it. Thanks. |
I'm not sure this is needed anymore after the work that got merged in #105. I ran our E2E tests against every version of WordPress from 5.7 onwards and I don't see any failing tests anymore. |
@dkotter I have verified the changes of this PR and it looks like we are good to close this PR and issue. @kmgalanakis Please feel free to reopen this if you are still facing the reported issue and we misunderstood anything here. Thank you |
Description of the Change
Closes #78
How to test the Change
Changelog Entry
Credits
Props @username, @username2, ...
Checklist: