Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair E2E tests #103

Closed
wants to merge 8 commits into from
Closed

Repair E2E tests #103

wants to merge 8 commits into from

Conversation

kmgalanakis
Copy link

Description of the Change

Closes #78

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@kmgalanakis kmgalanakis force-pushed the fix/repair-e2e-tests branch from 80a1a50 to 83d0126 Compare August 7, 2023 14:35
@kmgalanakis
Copy link
Author

@jeffpaul I don't know if I should specifically ping you about this.

I managed to fix the E2E tests by ignoring a CORS related error and by running them on Chrome (they were failing on Electron, objections?) but now I'm facing another test failure with WP trunk version. I consistently get an error like

Uncaught TypeError: Cannot destructure property 'documentElement' of 'contentDocument' as it is null.
    at HTMLIFrameElement.onLoad (block-editor.js?ver=35750e8f523ab571a7d8:25172:9)

when opening the editor using Cypress, something I don't get when loading the exact same site using my Chrome.

I don't know how to proceed, any suggestions?

@iamdharmesh
Copy link
Member

Hi @kmgalanakis,

Thank you for the PR.

I managed to fix the E2E tests by ignoring a CORS related error and by running them on Chrome (they were failing on Electron, objections?) but now I'm facing another test failure with WP trunk version. I consistently get an error like

Uncaught TypeError: Cannot destructure property 'documentElement' of 'contentDocument' as it is null.
   at HTMLIFrameElement.onLoad (block-editor.js?ver=35750e8f523ab571a7d8:25172:9)

This is a known issue with WP 6.3 and we have an open issue for it #104. It should be fixed separately from this PR. So, we can proceed here with ignoring it.

Thanks.
cc: @jeffpaul

@jeffpaul jeffpaul added this to the 0.2.0 milestone Aug 14, 2023
@dkotter dkotter modified the milestones: 0.2.0, 0.3.0 Aug 29, 2023
@dkotter
Copy link
Collaborator

dkotter commented Aug 29, 2023

I'm not sure this is needed anymore after the work that got merged in #105. I ran our E2E tests against every version of WordPress from 5.7 onwards and I don't see any failing tests anymore.

@iamdharmesh
Copy link
Member

@dkotter I have verified the changes of this PR and it looks like we are good to close this PR and issue.

@kmgalanakis Please feel free to reopen this if you are still facing the reported issue and we misunderstood anything here.

Thank you

@jeffpaul jeffpaul removed this from the 0.3.0 milestone Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken tests related to openDocumentSettingsPanel
4 participants