fix: remove wait for patterns to load

10up · Jun 7, 2022 · 2be2101 · 2be2101
1 parent a535b32
commit 2be2101
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/src/commands/check-block-pattern-exists.ts b/src/commands/check-block-pattern-exists.ts
@@ -41,8 +41,16 @@ export const checkBlockPatternExists = ({
     const { wp } = win;
 
     /* eslint-disable */
-    const { getSettings } = wp.data.select('core/block-editor');
-    const allRegisteredPatterns = getSettings().__experimentalBlockPatterns;
+    let allRegisteredPatterns = wp.data
+      .select('core/block-editor')
+      .getSettings().__experimentalBlockPatterns;
+
+    if (Array.isArray(allRegisteredPatterns) && !allRegisteredPatterns.length) {
+      cy.wait(1000);
+      allRegisteredPatterns = wp.data
+        .select('core/block-editor')
+        .getSettings().__experimentalBlockPatterns;
+    }
 
     if (undefined !== allRegisteredPatterns) {
       for (let i = 0; i < allRegisteredPatterns.length; i++) {

diff --git a/tests/cypress/integration/check-block-pattern-exists.test.js b/tests/cypress/integration/check-block-pattern-exists.test.js
@@ -19,9 +19,6 @@ describe('Command: checkBlockPatternExists', () => {
     testPatterns.forEach(testCase => {
       const shouldIt = testCase.expected ? 'should' : 'should not';
       it(`Pattern "${testCase.title}" ${shouldIt} exist in category "${testCase.cat}"`, () => {
-        // Wait for patterns to load on the post edit page.
-        cy.wait(1000);
-
         const args = {
           title: testCase.title,
         };