Ensure post type and taxonomy options are filterable via existing filters in the new React settings #831
Conversation
iamdharmesh
requested review from
dkotter,
jeffpaul and
a team
as code owners
github-actions
bot
added
the
needs:feedback
|
@iamdharmesh thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this? |
github-actions
bot
removed
the
needs:feedback
iamdharmesh
changed the title
| 'settings' => $this->get_settings(), | ||
| 'dashboardUrl' => admin_url( '/' ), | ||
| 'nonce' => wp_create_nonce( 'classifai-previewer-action' ), | ||
| 'postTypes' => $post_type_options, |
There was a problem hiding this comment.
This could be moved under features, but since we are using the get_post_types_for_language_settings helper function to retrieve post types, it has been kept here to continue using the same filter and avoid introducing unnecessary loop in the features data.
| /* | ||
| * Add NLU-specific taxonomies to the list if IBM Watson NLU is selected as the provider. | ||
| * | ||
| * This ensures that the NLU taxonomies are available in the settings, | ||
| * as NLU-specific taxonomies are registered only if the Classification feature is enabled and IBM Watson NLU is selected as the provider. | ||
| */ | ||
| if ( 'ibm_watson_nlu' === featureSettings.provider ) { | ||
| Object.keys( nluTaxonomies ).forEach( ( taxonomy ) => { | ||
| optionsObjects[ taxonomy ] = nluTaxonomies[ taxonomy ]; | ||
| } ); | ||
| } |
There was a problem hiding this comment.
Since IBM Watson NLU-specific taxonomies are registered only when the Classification feature is enabled and IBM Watson NLU is selected as the provider (saved in the database), and the page is no longer being reloaded, this ensures that those taxonomies are available in the settings. Open to discussing better alternative approaches to this.
Description of the Change
This PR updates feature settings to ensure that the post type and taxonomy options are filterable via existing PHP filters. In the new React settings, these post types and taxonomy options were fetched using
wp.datato enable easier filtration based on selections in the settings (e.g., hiding taxonomies of unchecked post types). However, as reported here, we identified that this JavaScript-based approach no longer supports the existing PHP filters. This PR revises how data is retrieved and used in the settings to maintain backward compatibility.How to test the Change
classifai_feature_classification_setting_taxonomiesfilter in the Classification feature settings.classifai_language_settings_post_typesfilter in the Classification, Excerpt Generation, and Text-to-Speech feature settings.classifai_feature_image_tags_generator_setting_taxonomiesfilter in the Image Tags Generator feature settings.Changelog Entry
Credits
Props @dkotter, @iamdharmesh, @Sidsector9
Checklist: