-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance/748: Updates to expand/condense text functionality #774
Conversation
@Sidsector9 I think @faisal-alvi's suggesting to use |
@@ -330,6 +360,26 @@ const ContentResizingPlugin = () => { | |||
</tbody> | |||
</table> | |||
</div> | |||
<p> | |||
{ __( | |||
'None of these suggestions are ideal, please', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with your thought here: #748 (comment). To me this reads as if something went wrong and we're giving an error message. It also doesn't make sense if someone has it set to only show a single result (suggestions
vs suggestion
).
I also wonder if a button makes more sense here, as that would stand out more, especially when the disable functionality is turned on, we already show a link here:
Something like this:
I also think Retry expanding/condensing the text
looks good here, so I'm fine with either text:
setModalTitle( __( 'Expanded text suggestions', 'classifai' ) ); | ||
} else { | ||
setModalTitle( __( 'Condensed text suggestions', 'classifai' ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be more complicated than what we care about but in the case where someone has it set to only display a single suggestion, suggestions
doesn't make sense at that point. Very minor thing so may be fine to just leave
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added here 6e9884d
Description of the Change
Closes #748
How to test the Change
Please follow the issue.
Changelog Entry
Credits
Props @jeffpaul @faisal-alvi @Sidsector9
Checklist: