-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utility to migrate settings #711
Conversation
@Sidsector9 thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this? |
0805395
to
3d9602c
Compare
Note: E2E tests are failing due to some issue in |
QA Update
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this and all seemed to work fine for me. There is potential for some confusion as we've rearranged some settings and changed how the role and user based access works (no longer showing extra checkboxes) but that all looks fine to me and the main things (like API keys) all come over correctly
One other thing to consider is we aren't deleting any of the old settings that are stored in options. I think that's okay for now, as it allows users to access that if something does go wrong in the migration process. But we probably want to look at cleaning that up in a release or two. |
Description of the Change
PR adds migration script to migrate existing configured settings to new feature first settings introduced in classifAI v3.
Closes #670
How to test the Change
trunk
branch, and build the plugin filesupkeep/670
Changelog Entry
Credits
Props @dkotter @Sidsector9 @iamdharmesh
Checklist: