Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the most recent version of the IBM Watson NLU API #543

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Jul 26, 2023

Description of the Change

We've been running the 2018-03-19 version of the IBM Watson NLU API for a number of years. According to their documentation, the latest version is 2022-08-10.

Ideally we should be running the latest versions of the various APIs we integrate with (where possible) so this PR updates the API version we make requests to. As far as I can tell in my testing, things still work as expected, no breaking changes were found. The actual results returned are different but that is expected with running a newer API version.

How to test the Change

  1. Ensure you have IBM Watson setup and configured properly
  2. Ensure classification works with all four features
  3. If desired, downgrade the API version back to 2018-03-19 and compare results to see what differences there are

Changelog Entry

Changed - Update the IBM Watson NLU API to the 2022-08-10 version.

Credits

Props @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter added this to the 2.3.0 milestone Jul 26, 2023
@dkotter dkotter self-assigned this Jul 26, 2023
@dkotter dkotter requested review from a team and jeffpaul as code owners July 26, 2023 22:14
@dkotter dkotter requested review from a team and ravinderk and removed request for a team and jeffpaul July 26, 2023 22:21
Copy link
Contributor

@ravinderk ravinderk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @dkotter, I also did not notice any difference. Between results from different IBM Watson API

@dkotter dkotter merged commit dd050d4 into develop Aug 2, 2023
@dkotter dkotter deleted the feature/update-ibm-watson-api branch August 2, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants