-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TTS: Provide option to disable auto re-generation of audio upon post content update. #540
Comments
I'm wondering if we need a new setting for this? I guess I'm thinking that once audio generation has happened, we automatically set the existing toggle to off. At that point, we just need to add in a They're may be some that don't like this and that's where a setting comes in handy, just worried about settings fatigue here. |
@dkotter I do agree that we can possibly make this workflow more intuitive and this could get a bit confusing too if just keep adding settings, but currently, the audio generation toggle you are talking about is also responsible for hiding the audio version from displaying on the frontend. |
@joshuaabenazer Ah, right, forgot we had made that change. What if we kept the toggle on after the audio is generated but we disable it and add a message explaining that processing won't happen again unless manually triggered? |
@dkotter so that means we are defaulting to hit the regenerate button incase we want the audio updated for any reason and ditching the setting? Yeah that sounds good. Let me know if that works and I can get started on this. |
That's how I envision it working. Once audio has been generated once, disable the toggle and show the
Yeah, if there's an easy way to provide an override here, that would be great. |
@dkotter the toggle is tied to the display on FE so I don't think we should touch that but otherwise, I think this works. I will work on getting some code for this to start with and then we can discuss how to change it up if needed on the PR. |
@joshuaabenazer In thinking about this more, wondering if we need to change slightly the toggle we have. I know we discussed having just a single toggle and having that control not only whether audio is generated but also control if the audio gets output on the front end. Apologies but I don't recall all the nuances of that discussion so maybe something I'm forgetting on why that was the best approach but wondering if we should introduce a new toggle to handle display. At the moment, I don't think it's clear to users that if they turn that toggle off, not only will audio not be generated but the display will also not happen. It also makes this task a little trickier if we have a single toggle that is doing two different things. So thinking we may want to introduce a new toggle to handle the audio display, along with the existing toggle that determines if audio is generated or not. I think this makes a clearer UI and helps resolve the issue documented here. Basically we could automatically disable the generation toggle once audio has been generated once but keep the display toggle on. This way audio isn't generated more than once unless someone manually clicks the That said, I know this was discussed previously so there may be something I'm forgetting from that conversation and we may want to keep these in a single toggle. |
…ified. Make TTS 5.7 compatible.
…n toggle states. Keep the TTS voice selected value intact incase the service is reconnected.
…y-optimization #540 - Audio Generation Cleanup / Optimization / Display
Is your enhancement related to a problem? Please describe.
Currently when the content of a post is updated even though it may be correcting punctuations ( or spelling corrections or anything other minor corrections for that matter ), if an audio version of the post already exists, it will re-generate the audio based on the updated content.
Trying to be cost effective with the service being used here, it would be great if there was a setting to disable this auto regeneration of the audio, and if so allow the editors of the post to explicitly click a button to regenerate audio when they feel it makes sense.
Designs
Describe alternatives you've considered
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: