Ensure we avoid running our update functionality multiple times

10up · Jan 31, 2024 · 28381c8 · 28381c8
1 parent 36aac2d
commit 28381c8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/includes/Classifai/Features/DescriptiveTextGenerator.php b/includes/Classifai/Features/DescriptiveTextGenerator.php
@@ -263,6 +263,8 @@ public function maybe_rescan_image( int $attachment_id ) {
 			$result = $this->run( $attachment_id, 'descriptive_text' );
 
 			if ( $result && ! is_wp_error( $result ) ) {
+				// Ensure we don't re-run this when the attachment is updated.
+				remove_action( 'edit_attachment', [ $this, 'maybe_rescan_image' ] );
 				$this->save( $result, $attachment_id );
 			}
 		}

diff --git a/includes/Classifai/Features/ImageTextExtraction.php b/includes/Classifai/Features/ImageTextExtraction.php
@@ -301,6 +301,8 @@ public function maybe_rescan_image( int $attachment_id ) {
 			$result = $this->run( $attachment_id, 'ocr' );
 
 			if ( $result && ! is_wp_error( $result ) ) {
+				// Ensure we don't re-run this when the attachment is updated.
+				remove_action( 'edit_attachment', [ $this, 'maybe_rescan_image' ] );
 				$this->save( $result, $attachment_id );
 			}
 		}

diff --git a/includes/Classifai/Features/PDFTextExtraction.php b/includes/Classifai/Features/PDFTextExtraction.php
@@ -211,6 +211,9 @@ public function maybe_rescan_pdf( int $attachment_id ) {
 	 * @param int    $attachment_id The attachment ID.
 	 */
 	public function save( string $result, int $attachment_id ) {
+		// Ensure we don't re-run this when the attachment is updated.
+		remove_action( 'edit_attachment', [ $this, 'maybe_rescan_pdf' ] );
+
 		return wp_update_post(
 			[
 				'ID'           => $attachment_id,