Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix namespace validation error #346

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Fix namespace validation error #346

merged 1 commit into from
Nov 18, 2024

Conversation

palicko
Copy link
Contributor

@palicko palicko commented Nov 18, 2024

Description of the Change

This fixes namespace validation error when registerBlockExtension is used with * to target all blocks. Error prevents extension from registering correctly.

Closes #345

How to test the Change

Error is no longer present and extension works as it should.

Changelog Entry

Fixed - Bug fix

Checklist:

fabiankaegy
fabiankaegy approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you :)

@fabiankaegy fabiankaegy merged commit 6d447f5 into 10up:develop Nov 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiankaegy fabiankaegy fabiankaegy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using * in registerBlockExtension throws namespace validation error
2 participants
@palicko @fabiankaegy