Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: defaultProps & propTypes definitions from remaining components #331

Merged
merged 20 commits into from
Jun 11, 2024

Conversation

fabiankaegy
Copy link
Member

Description of the Change

The end goal still is to convert all of these to TypeScript as tracked in #295. However this is meant to close #314 before WordPress 6.6

Closes #314

Changelog Entry

Changed - Refactor defaultProps to inline default assignements
Removed - prop-types definition from the codebase

Credits

Props @fabiankaegy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@fabiankaegy fabiankaegy self-assigned this Jun 11, 2024
@fabiankaegy fabiankaegy merged commit 7fa9778 into develop Jun 11, 2024
5 of 8 checks passed
@fabiankaegy fabiankaegy deleted the fix/remove-prop-types-dependency branch June 11, 2024 10:26
Copy link

Size Change: -65.8 kB (-50.58%) 🏆

Total Size: 64.3 kB

Filename Size Change
dist/index.js 64.3 kB -65.8 kB (-50.58%) 🏆

compressed-size-action

@cypress cypress bot mentioned this pull request Jun 11, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate away from defaultProps
1 participant